Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(studio): Quick fix for trace rendering bug #9120

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Not designed to be permanent. Studio is being ported to a redwood project instead.

Not designed to be permanent. Studio is being ported to a redwood project instead.
@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Sep 1, 2023
@Josh-Walker-GM Josh-Walker-GM added this to the next-release-patch milestone Sep 1, 2023
const bigIntMin = (...args: bigint[]) =>
args.reduce((m, e) => (e < m ? e : m))

const traces: any[] = data?.rows !== undefined ? [...data.rows] : []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but let's see later if we can do sorting in the service/view/queries perhaps? Maybe a sort option?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed

Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) September 2, 2023 00:22
@Josh-Walker-GM Josh-Walker-GM merged commit 46f332c into main Sep 2, 2023
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw-studio/quick-fix branch September 2, 2023 00:51
jtoar pushed a commit that referenced this pull request Sep 2, 2023
Not designed to be permanent. Studio is being ported to a redwood
project instead.
@jtoar jtoar modified the milestones: next-release-patch, v6.1.1 Sep 2, 2023
jtoar pushed a commit that referenced this pull request Sep 2, 2023
Not designed to be permanent. Studio is being ported to a redwood
project instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants